-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chain): Use network kind of TestnetKind
in transparent addresses on Regtest
#9175
Conversation
On the zingolib side, I've tracked the error through to a call to
|
Reproduced the same on my side.
it seems that zingolib is expecting something like
and got something really different ? (see |
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
@Mergifyio update |
✅ Branch has been successfully updated |
@mergify requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
@mergify refresh |
✅ Pull request refreshed |
@mergify refresh |
✅ Pull request refreshed |
Motivation
The non-finalized transparent transfer state is storing tx ids spending to or receiving from an address by getting addresses from outputs and assigning the node network's kind as the address network kind. This makes it difficult to query address tx ids or balances because Regtest transparent addresses use the same b58 address prefixes as Testnet, and addresses with the Regtest prefix are parsed as Testnet addresses in most of Zebra.
Closes #9161.
Solution
RegtestKind
Related:
Tests
Covered by Zaino's
zebrad_send_to_transparent
test (see note on modifications)PR Author's Checklist
PR Reviewer's Checklist